Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Closing Survey Feature, User Entity Feature, and Perform Authorization Checks Feature #54

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

GillesMyny1
Copy link
Owner

This feature update includes the following:

  • A User entity is now available, a User can be an ADMIN or STANDARD
  • You must login at /index now as either an ADMIN or STANDARD
  • Limited functionality has been put in place for STANDARD roles
  • ADMIN roles can close Survey objects to view the results
  • All appropriate tests for the User entity

Added User Entity and Perform Authorization Checks
@GillesMyny1 GillesMyny1 added the help wanted Extra attention is needed label Mar 23, 2023
@GillesMyny1 GillesMyny1 added this to the Milestone 3 milestone Mar 23, 2023
@GillesMyny1 GillesMyny1 self-assigned this Mar 23, 2023
@GillesMyny1
Copy link
Owner Author

Please discuss below about any comments or improvements that can be made.

@GillesMyny1
Copy link
Owner Author

This pull request covers the following issues #51 and #52

@dowy24
Copy link
Collaborator

dowy24 commented Mar 24, 2023

Hi Gilles, good work on this new feature. How do I access the survey? Is there a default admin Username and Password or is there an option to create one?

@GillesMyny1
Copy link
Owner Author

Hi Gilles, good work on this new feature. How do I access the survey? Is there a default admin Username and Password or is there an option to create one?

Hey, thanks. As this is a software that is delivered to a client (the admin) and their users (the standard) there is currently functionality for an admin and standard users. Meaning that a client would setup both accounts, prepare the surveys, and send out the standard login info to their users.

The admin username and password are both "admin" for testing purposes.
The standard username and password are both "standard" for testing purposes.

@joshua-gatto
Copy link
Collaborator

How are the individual URLs protected from user input when they are not logged in, or do not have access to said functionality?

@GillesMyny1
Copy link
Owner Author

How are the individual URLs protected from user input when they are not logged in, or do not have access to said functionality?

Each URL get mapping has protections set in place to not only check if a session exists, where nobody is logged in, but also to check if the active session has admin or standard privileges.

Meaning that a user can only access URLs that their respective access rights allow.

@dowy24 dowy24 merged commit 872054e into master Mar 24, 2023
@dowy24 dowy24 deleted the authorization_feature branch March 24, 2023 15:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Extra attention is needed
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants