Skip to content

Update broken link in README.md #179

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
May 13, 2021
Merged

Update broken link in README.md #179

merged 4 commits into from
May 13, 2021

Conversation

BlakeBarrett
Copy link
Contributor

Links and bold were using markdown format, but weren't being interpreted as links.
Converted from markdown [link](url) format to HTML <a href="link">words</a> format.

Links and bold were using markdown format, but weren't being interpreted as links.
Converted from markdown `[link](url)` format to HTML `<a href="link">words</a>` format.
@BlakeBarrett
Copy link
Contributor Author

Thanks for the approval @nbransby. It looks like you may need to trigger the build as it is telling me:

1 workflow awaiting approval
First-time contributors need a maintainer to approve running workflows.

Thanks!

@BlakeBarrett
Copy link
Contributor Author

Hi again @nbransby.
This fix isn't super critical, but I'd like to get it merged so I can delete my fork.

This is what I see when trying to merge this PR, I believe you just need to kick off a build (or approve me to run that workflow.)
1 workflow awaiting approval
First-time contributors need a maintainer to approve running workflows. Learn more.
1 expected check

"1 workflow awaiting approval
First-time contributors need a maintainer to approve running workflows. Learn more.
1 expected check"

@nbransby
Copy link
Member

yes had to fix the build first 😅

@nbransby nbransby merged commit 7733c7c into GitLiveApp:master May 13, 2021
@BlakeBarrett
Copy link
Contributor Author

yes had to fix the build first 😅

Awesome! Thanks so much @nbransby

@BlakeBarrett BlakeBarrett deleted the patch-1 branch May 13, 2021 22:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants