Implement Firebase remote config API

[shepeliev]

Closes #134
Closes #172

[nbransby]

Hey thanks @shepeliev this looks great! Couple of suggestions:

• We try and match the android ktx library api as closely as possible:
• For example you should remove getValue from the FirebaseRemoteConfig and just replace with the operator version that the kotlin extensions adds

[shepeliev]

Hey thanks @shepeliev this looks great! Couple of suggestions:

• We try and match the android ktx library api as closely as possible:
• For example you should remove getValue from the FirebaseRemoteConfig and just replace with the operator version that the kotlin extensions adds

Thanks for reviewing. Yes, it makes sense. I'll rework it soon.

[nbransby]

Actually why dont we go one step further and use a reified type param to also replace all the get*Type* methods, e.g:

    inline operator fun <reified T> get(key: String): T = when(T::class) {
        String::class -> android.getString(key)
        FirebaseRemoteConfigValue::class -> android.getValue(key)
        ...
        else -> throw IllegalArgumentException()
    } as T

[shepeliev]

Actually why dont we go one step further and use a reified type param to also replace all the get*Type* methods, e.g:

    inline operator fun <reified T> get(key: String): T = when(T::class) {
        String::class -> android.getString(key)
        FirebaseRemoteConfigValue::class -> android.getValue(key)
        ...
        else -> throw IllegalArgumentException()
    } as T

That looks great. Just pushed an update.

[suntrix]

@nbransby any ideas when this will be merged?

[Reedyuk]

@shepeliev - is it possible to rename it? Google refers to theirs as the project being called firebase-config and their imports are Firebase.remoteConfig(you have done the import object right, its just the name of the project/directories that needs changing).

[Reedyuk]

Rest looks great!

[shepeliev]

@shepeliev - is it possible to rename it? Google refers to theirs as the project being called firebase-config and their imports are Firebase.remoteConfig(you have done the import object right, its just the name of the project/directories that needs changing).

Yep, you are right about naming the project. I think I'll do it in a couple of hours tonight.