-
Notifications
You must be signed in to change notification settings - Fork 166
Added firebase-installations #257
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
🥳 I initially did that, but then I noticed they have a separate namespace for it & moved it to separate module. |
namespace as in package name in android? Yes I think its best to move it back as there is nothing to be gained from separate package (no reduction in dependencies if not using the installations api) |
|
||
val androidMain by getting { | ||
dependencies { | ||
api("com.google.firebase:firebase-installations") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbransby Actually there's a separate package for Android, so probably makes sense to leave it as separate module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbransby Can you take a look? I have some more PRs in my pipeline :)
@nbransby any possibility to merge it this week? |
No description provided.