Skip to content

Add support/handling for FirebaseAuthWeakPasswordException #387

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 17, 2023

Conversation

Bradleycorn
Copy link
Contributor

@Bradleycorn Bradleycorn commented Jun 16, 2023

Addresses #289 by adding support for the FirebaseAuthWeakPasswordException (https://firebase.google.com/docs/reference/kotlin/com/google/firebase/auth/FirebaseAuthWeakPasswordException) in the firebase-auth module.

  • Marks FirebaseAuthInvalidCredentialsException as open so that it can be inherited from (more info below).
  • Adds a new class FirebaseAuthWeakPasswordException that inherits from FirebaseAuthInvalidCredentialsException. This is done for two reasons:
    1. In Firebase itself, the weak password exception inherits from the invalid credentials exception. This keeps that same structure in this library.
    2. It prevents breaking changes. Existing code in consumer applications that is expecting FirebaseAuthInvalidCredentialsException will continue to function normally, since the new FirebaseAuthWeakPasswordException IS a FirebaseAuthInvalidCredentialsException.
  • Implements the FirebaseAuthWeakPasswordException for all platforms (android, iOS, js).

@Bradleycorn
Copy link
Contributor Author

Bradleycorn commented Jun 16, 2023

@Reedyuk - The assemble task on the Pull Request build has been running for 5 hours .. That seems ... not right. Any ideas? I can ./gradlew assemble this branch on my machine and it builds fine.

@Reedyuk
Copy link
Collaborator

Reedyuk commented Jun 16, 2023

I've cancelled it and reran it, there is a pr with kotlin bump to fix it

Copy link
Member

@nbransby nbransby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff, thanks @Bradleycorn

@nbransby nbransby merged commit 2fc9c04 into GitLiveApp:master Jun 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants