Move FieldPath.documentId to companion object #487

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Merged

nbransby merged 2 commits into GitLiveApp:master from splendo:feature/fix-fieldpath-documentid

Apr 3, 2024

Contributor

Daeda88 commented Apr 3, 2024 •

edited

Loading

Reason for this move is that:

It is a static property so it should be in a companion object
At least on iOS, doing FieldPath().documentId would crash since fieldPath needs at least one fieldName. So you'd have to call FieldPath("fakePath").documentId which is obviously not good

Daeda88 added 2 commits

April 3, 2024 12:19


          Move FieldPath.documentId to companion object

105109b


          Added test

38b6a9c

nbransby merged commit f808163 into GitLiveApp:master

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet