Fix tag normalization for Azure Pipelines #4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bi0T1N
reviewed
Feb 1, 2025
| ?? Environment.GetEnvironmentVariable("BUILD_SOURCEBRANCH"); | ||
| public override string? GetCurrentBranch(bool usingDynamicRepos) | ||
| { | ||
| var gitBranch = Environment.GetEnvironmentVariable("GIT_BRANCH"); |
There was a problem hiding this comment.
Where does this variable come from? I can only find references that refer to Jenkins
There was a problem hiding this comment.
It's an environment variable we've adopted in GitVersion as a way for the build environment to indicate which branch is being built. But as you can see from #3049, support for the variable is not fully implemented.
There was a problem hiding this comment.
Any updates on this? It's annoying to have versions like 1.1.3-tags-1-1-1.1 created.
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
arturcic
force-pushed
the
fix-tag-normalization-azure-pipelines
branch
2 times, most recently
from
ac3e804 to
9925542
Compare
arturcic
approved these changes
Apr 1, 2025
|
@asbjornu mind to check this one? |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
asbjornu
force-pushed
the
fix-tag-normalization-azure-pipelines
branch
from
9925542 to
d587fce
Compare
|
Thank you @ChristopherMann for your contribution! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the Azure Pipelines agent so it does not return tag names as branch names.
Related Issue
#4015
Motivation and Context
Azure Pipelines provides the name of the tag for which the pipeline has been triggered in
BUILD_SOURCEBRANCHasrefs/tags/<tag>. When we do not ignore the tags in the Azure Pipelines agent, the repository normalization will normalizethe tag name
refs/tags/<tag>to the local branch nametags/<tag>. This leads to an incorrect calculation of prerelease labels(e.g.
tags-v1.2.3-beta.1) .A similar issue has been fixed for GitHub Actions in #2838.
How Has This Been Tested?
Unit tests have been added for the Azure Pipelines agent.
Checklist: