Drop once_cell
#1518
Drop once_cell
#1518
Conversation
This almost completely drops the `once_cell` crate, but `OnceCell` is still in use. While the `OnceCell` type is available in the standard library, the `get_or_try_init` method is not yet stabilized. This bumps the MSRV up to 1.80, which is the first version to stabilize `std::sync::LazyLock`.
spenserblack
force-pushed
the
chore/std-lazylock
branch
from
a020c10 to
acd33f4
Compare
|
Thanks for the initiative, it's much appreciated! It seems a bit early, especially since you have to keep maintaining this PR for however long it takes until the MSRV can be 1.80, but I suppose this is acceptable to you. My recommendation is to track the MSRV of |
Does this mean that, as helix's MSRV is updated, |
|
Yes, that's usually what I do. |
|
Would you consider reopneing the PR once it has a chance to actually be merged? |
|
Sure! Up to you how you want to manage this project, but what I had in mind is that this could sit around as a "to do" that I'd check in with occasionally. |
|
I think that works similarly (from your side) on a closed PR. If CI is needed, it's possible to enable it on your fork, and it will run automatically for all branches named Right now there are a lot of mostly stale PRs and this one I think will be around for quite a few months until 1.80 is the new baseline MSRV. |
|
No problem, I'll check in a while later. Unless someone else remakes this PR before I get back to it 😆 |
The ecosystem seems to be moving away from using the
once_cellcrate towards using the types available in the standard library. In particular,once_cell::sync::Lazyis getting replaced bystd::sync::LazyLock, which is mostly a drop-in replacement.As
LazyLockwas stabilized in 1.80, this is a drastic increase in the MSRV, so this probably shouldn't be merged for a while. I'm not sure what the MSRV policy is, but I haven't really searched too deeply for it, yet. X versions back? X months back?Leaving this in a draft status until:
std::cell::OnceCell::get_or_try_initis stabilized