Credentials helper launching in all its variety #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's special as it creates its own repository.
Previously this was hard-coded to `radicle`, now it's just an extension scheme along with a statically known string. This means we have to explicitly support new formats which should be fine.
…upport (#450) No leniency because it's hard to decide what to do, allowing connections is probably not it, so better fail with the correct error message.
…450) This wasn't supposed to happen but a requirement to get `serde` support back.
align usage of stdin and stdout to factor it elsewhere.
…for more flexible helper invocation (#450)
avoid using actual credentials helper where none is required
…module. (#450) Also allow to pass arbitrary bytes (more or less) as context by not forcing it all into a string. Values can now be everything, which helps with passing paths or other values.
…mes. (#450) Have to represent names or urls seprately or risk this to be a hazard for any caller.
Conflicts: cargo-smart-release/Cargo.toml experiments/diffing/Cargo.toml experiments/object-access/Cargo.toml experiments/traversal/Cargo.toml git-attributes/Cargo.toml git-config/Cargo.toml git-odb/Cargo.toml git-pack/Cargo.toml git-ref/Cargo.toml git-repository/Cargo.toml git-url/Cargo.toml gitoxide-core/Cargo.toml
…redential-lite` (#450)
Needs integration with Repo configuration, which includes prompt options actually.
…lled with all arguments (#450)
When true, default false, inject the git installation configuration file if present at the cost of one `git config` invocation. Note that we rely on the underlying `git-config` crate to not load duplicate files. We also currently lie about the scope which is actually unclear - have seen 'unknown' or normal scopes like `system`.
#450) This is important as it may contain additional credential helper configuration that we definitely need to find the credentials that git usually finds.
8 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
protocol.*.allowsupport helper functions (instead of programs)no need, only interesting for testing actuallygit-commandto spawn commands 'git-style' and eventually also hooks, somewhat similar torun-command.c.credential.helperconfiguration (via git-sec)git-promptexpectrldriven testgitinvocations.- on MacOS
/usr/bin/gitthe 'system' config is scope 'unknown' and would need to be parsed via-l --show-originand the first line is the path. '--system' is not present. On windows,--systemworks as expected and these count as installation directory.gix remote refsfor non-symbolic remote, like in PR checkoutsgix credentialas equivalent togit credential, just for funNext PR
git-secremove tag fromAccess, make acheckthat only returns onOption, ignoringDeny.Out of scope
branch.<name>.mergesupport, as we don't yet merge anything and fetching still fetches the entire refspec of as configured in the remote.Predecessor