Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dashboard: Add push button feature #2165

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • [ ]

Description of change

Kapture.2024-11-08.at.15.29.49.mp4

Copy link

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 445a361
Status: ✅  Deploy successful!
Preview URL: https://77360b59.gladys-plus.pages.dev
Branch Preview URL: https://push-button-feature.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (37f76c4) to head (445a361).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2165   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files         867      867           
  Lines       14243    14243           
=======================================
  Hits        14030    14030           
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Nov 8, 2024

#2853 Bundle Size — 10.26MiB (+0.02%).

445a361(current) vs 37f76c4 master#2849(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 2 regressions
                 Current
#2853
     Baseline
#2849
Regression  Initial JS 5.56MiB(+0.01%) 5.55MiB
Regression  Initial CSS 304.73KiB(+0.02%) 304.68KiB
Change  Cache Invalidation 66.33% 0%
No change  Chunks 51 51
No change  Assets 171 171
Change  Modules 1496(+0.07%) 1495
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.84% 0.84%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#2853
     Baseline
#2849
Regression  JS 7.34MiB (+0.03%) 7.34MiB
No change  IMG 2.48MiB 2.48MiB
Regression  CSS 321.52KiB (+0.02%) 321.47KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch push-button-featureProject dashboard


Generated by RelativeCIDocumentationReport issue

@Pierre-Gilles Pierre-Gilles merged commit 68cdb6c into master Nov 11, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the push-button-feature branch November 11, 2024 08:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant