Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Integration List: Fix scroll to top bug #2227

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Fix https://community.gladysassistant.com/t/mqtt-liste-des-devices/9348

Copy link

cloudflare-workers-and-pages bot commented Feb 10, 2025

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 15a3fdd
Status: ✅  Deploy successful!
Preview URL: https://f0814955.gladys-plus.pages.dev
Branch Preview URL: https://integration-list-fix-scroll.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (6edd550) to head (15a3fdd).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2227   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         877      877           
  Lines       14519    14519           
=======================================
  Hits        14308    14308           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Feb 10, 2025

#3018 Bundle Size — 10.42MiB (+0.01%).

15a3fdd(current) vs 6edd550 master#3010(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes
                 Current
#3018
     Baseline
#3010
No change  Initial JS 5.65MiB 5.65MiB
No change  Initial CSS 304.87KiB 304.87KiB
Change  Cache Invalidation 54.18% 54.11%
No change  Chunks 51 51
No change  Assets 173 173
Change  Modules 1513(+0.07%) 1512
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.84% 0.84%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 6 changes Regression 6 regressions
                 Current
#3018
     Baseline
#3010
Regression  JS 7.44MiB (+100%) undefined
Regression  IMG 2.54MiB (+100%) undefined
Regression  CSS 321.77KiB (+100%) undefined
Regression  Fonts 93.55KiB (+100%) undefined
Regression  Other 17.79KiB (+100%) undefined
Regression  HTML 13.58KiB (+100%) undefined

Bundle analysis reportBranch integration-list-fix-scroll-to-t...Project dashboard


Generated by RelativeCIDocumentationReport issue

@Pierre-Gilles Pierre-Gilles merged commit 587e49c into master Feb 10, 2025
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the integration-list-fix-scroll-to-top branch February 10, 2025 13:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant