-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update wrapper for v1.89.4 #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnimuc
approved these changes
Aug 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this as long as the upstreams are updated.
JamesWrigley
force-pushed
the
v1.89.4-update
branch
from
August 16, 2023 23:13
847f298
to
5178cef
Compare
I yanked CImGuiPack_jll-v0.1.3 and tagged a new version v0.2.0. |
Overview of changes: - Lots of functions now have an underscore between the C function name and the parameter type, e.g. `igFooStr` -> `igFoo_Str`. - Some functions were completely renamed, which I've marked with `@deprecate`. - Some functions were deleted entirely, like `CalcListClipping()`.
Ported from a C++ example.
Note: this requires a version of ImGuiOpenGLBackend with JuliaImGui/ImGuiOpenGLBackend.jl#4.
JamesWrigley
force-pushed
the
v1.89.4-update
branch
from
September 7, 2023 08:55
590af98
to
b5cd513
Compare
@Gnimuc, I think this is ready to merge now? |
Thanks! |
@JamesWrigley is this ready for a new release? or you're still experimenting with something? |
Nope, this should be ready to go 👍 |
Closed
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of changes:
igFooStr
->igFoo_Str
.@deprecate
.CalcListClipping()
.I've tested this with the
demo/demo.jl
andexamples/demo.jl
and everything seems to work.Depends on: