Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update wrapper for v1.89.4 #87

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Conversation

JamesWrigley
Copy link
Collaborator

Overview of changes:

  • Lots of functions now have an underscore between the C function name and the parameter type, e.g. igFooStr -> igFoo_Str.
  • Some functions were completely renamed, which I've marked with @deprecate.
  • Some functions were deleted entirely, like CalcListClipping().

I've tested this with the demo/demo.jl and examples/demo.jl and everything seems to work.
Depends on:

Copy link
Owner

@Gnimuc Gnimuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this as long as the upstreams are updated.

@JamesWrigley
Copy link
Collaborator Author

Added a port of this demo in 9f84a0f to test handling large meshes.

@Gnimuc
Copy link
Owner

Gnimuc commented Aug 31, 2023

I yanked CImGuiPack_jll-v0.1.3 and tagged a new version v0.2.0.

cc @JamesWrigley

Overview of changes:
- Lots of functions now have an underscore between the C function name and the
  parameter type, e.g. `igFooStr` -> `igFoo_Str`.
- Some functions were completely renamed, which I've marked with `@deprecate`.
- Some functions were deleted entirely, like `CalcListClipping()`.
Ported from a C++ example.
Note: this requires a version of ImGuiOpenGLBackend with
JuliaImGui/ImGuiOpenGLBackend.jl#4.
@JamesWrigley
Copy link
Collaborator Author

@Gnimuc, I think this is ready to merge now?

@Gnimuc Gnimuc merged commit 2883aac into Gnimuc:master Sep 22, 2023
6 checks passed
@Gnimuc
Copy link
Owner

Gnimuc commented Sep 22, 2023

Thanks!

@JamesWrigley JamesWrigley deleted the v1.89.4-update branch September 22, 2023 07:26
@Gnimuc
Copy link
Owner

Gnimuc commented Sep 23, 2023

@JamesWrigley is this ready for a new release? or you're still experimenting with something?

@JamesWrigley
Copy link
Collaborator Author

Nope, this should be ready to go 👍

@JamesWrigley JamesWrigley mentioned this pull request Sep 29, 2023
@JamesWrigley JamesWrigley mentioned this pull request Nov 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants