Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add load before functionality #114

Closed
Tracked by #181
KANAjetzt opened this issue Feb 15, 2023 · 2 comments
Closed
Tracked by #181

Add load before functionality #114

KANAjetzt opened this issue Feb 15, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@KANAjetzt
Copy link
Member

KANA — Yesterday at 16:46
I need a way to tell a mod ( Darkly77-ContentLoader ) that it has to wait for my mod ( KANA-WhatAmILookingAt )

Ste — Yesterday at 16:49
technically only by dependencies.. we could introduce a "load-before" to store more mod ids that should load after this mod
load before would essentially copy over the importance score of the other mod and add it to the own importance

@KANAjetzt KANAjetzt added the enhancement New feature or request label Feb 15, 2023
@KANAjetzt KANAjetzt added this to the v4.3.0 milestone Feb 15, 2023
@KANAjetzt KANAjetzt self-assigned this Feb 15, 2023
@KANAjetzt
Copy link
Member Author

Load before field in the manifest.json in extra -> godot -> load_before
"load_before": ["Darkly77-ContentLoader"],

{
	"name": "WhatAmILookingAt",
	"namespace": "KANA",
	"version_number": "1.0.0",
	"description": "Tells you where this thing is from.",
	"website_url": "https://github.com/BrotatoMods",
	"dependencies": [],
	"extra": {
		"godot": {
			"incompatibilities": [],
			"load_before": ["Darkly77-ContentLoader"],
			"authors": ["KANA"],
			"compatible_mod_loader_version": "4.3.0",
			"compatible_game_version": ["0.8.0.3"],
			"config_defaults": {}
		}
	}
}

@KANAjetzt KANAjetzt mentioned this issue Mar 23, 2023
37 tasks
KANAjetzt added a commit to KANAjetzt/godot-mod-loader that referenced this issue Mar 24, 2023
Adds functionality to specify a mod you want to load before your own mod.

closes GodotModding#114
KANAjetzt added a commit that referenced this issue Mar 25, 2023
* feat: ✨ added load_before

Adds functionality to specify a mod you want to load before your own mod.

closes #114

* fix: 🐛 check if id already in the dependency array

Makes sure the mod with the `load_before` in the manifest, is not added a second time to the mod specified in the `load_before` array.

* fix: 🐛 Check if the `load_before` mod exists

* fix: 🐛 wrong whitespace
@KANAjetzt
Copy link
Member Author

closed by #185

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant