Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor: Move utility funcs out of mod_manifest.gd #165

Closed
3 tasks done
Tracked by #181
ithinkandicode opened this issue Mar 2, 2023 · 1 comment
Closed
3 tasks done
Tracked by #181

Refactor: Move utility funcs out of mod_manifest.gd #165

ithinkandicode opened this issue Mar 2, 2023 · 1 comment
Assignees
@KANAjetzt
Labels
refactor / cleanup Improves readability or maintainability
Milestone
3.x - v6.0.0

Comments

@ithinkandicode
Copy link
Collaborator

ithinkandicode commented Mar 2, 2023 •
edited by KANAjetzt
Loading

Atm there are three methods in mod_manifest.gd that look like they should be in mod_loader_utils.gd:

  • _get_string_from_dict
  • _get_array_from_dict
  • dict_has_fields
@ithinkandicode ithinkandicode added the refactor / cleanup Improves readability or maintainability label Mar 2, 2023
@KANAjetzt KANAjetzt self-assigned this Mar 5, 2023
@KANAjetzt KANAjetzt added this to the v6.0.0 milestone Mar 13, 2023
@KANAjetzt KANAjetzt mentioned this issue Mar 23, 2023
Closed
37 tasks
KANAjetzt added a commit that referenced this issue Mar 23, 2023
@KANAjetzt
refactor: ♻️ Move utility funcs out of *mod_manifest.gd*
52b9eda 
Moves `_get_string_from_dict()`,  `_get_array_from_dict()` and  `dict_has_fields()` from *mod_manifest.gd* to *mod_loader_utils.gd*

closes #165
@KANAjetzt KANAjetzt mentioned this issue Mar 23, 2023
Merged
KANAjetzt added a commit that referenced this issue Mar 24, 2023
@KANAjetzt
refactor: ♻️ Move utility funcs out of *mod_manifest.gd* (#182)
2776655 
Moves `_get_string_from_dict()`,  `_get_array_from_dict()` and  `dict_has_fields()` from *mod_manifest.gd* to *mod_loader_utils.gd*

closes #165
@ithinkandicode
Copy link
Collaborator Author

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@KANAjetzt KANAjetzt

Labels
refactor / cleanup Improves readability or maintainability
Projects
None yet
Milestone
3.x - v6.0.0
Development

No branches or pull requests
2 participants
@KANAjetzt @ithinkandicode