Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ModManifest Validation - Make sure error messages include a reference to the mod that cause the validation error #173

Closed
2 tasks done
Tracked by #181
KANAjetzt opened this issue Mar 6, 2023 · 1 comment
Closed
2 tasks done
Tracked by #181

ModManifest Validation - Make sure error messages include a reference to the mod that cause the validation error #173

KANAjetzt opened this issue Mar 6, 2023 · 1 comment
Labels
enhancement New feature or request validation Feature to make things safe and predictable
Milestone
3.x - v6.0.0

Comments

@KANAjetzt
Copy link
Member

KANAjetzt commented Mar 6, 2023 •
edited
Loading

As @ithinkandicode mentioned on Discord, the deprecation warning of compatible_mod_loader_version doesn't include the mod id, it is caused by. This requires the user to follow the stack trace and check the data himself. We can make that process easier by adding the mod id to the error message.

image

From a quick first look this functions need this treatment:

  • _handle_compatible_mod_loader_version()
  • is_semver_valid()
@KANAjetzt KANAjetzt added enhancement New feature or request validation Feature to make things safe and predictable labels Mar 6, 2023
@KANAjetzt KANAjetzt mentioned this issue Mar 23, 2023
Closed
37 tasks
@KANAjetzt KANAjetzt added this to the v6.0.0 milestone Mar 23, 2023
KANAjetzt added a commit to KANAjetzt/godot-mod-loader that referenced this issue Mar 29, 2023
@KANAjetzt
refactor: ♻️ add mod_id in all validation error messages
4c53ccd 
Also changes all single quotes to double quotes as discussed in GodotModding#166 and fixes a critical bug that caused the validation to break on `if is_semver_valid(version_number):` - added the `not` to fix that.

closes GodotModding#173
@KANAjetzt KANAjetzt mentioned this issue Mar 29, 2023
Merged
KANAjetzt added a commit that referenced this issue Mar 30, 2023
@KANAjetzt
refactor: ♻️ add mod_id in all validation error messages (#197)
0bbf74b 
Also changes all single quotes to double quotes as discussed in #166 and fixes a critical bug that caused the validation to break on `if is_semver_valid(version_number):` - added the `not` to fix that.

closes #173
@KANAjetzt
Copy link
Member Author

closed by #197

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request validation Feature to make things safe and predictable
Projects
None yet
Milestone
3.x - v6.0.0
Development

No branches or pull requests
1 participant
@KANAjetzt