Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

incompatibility should not be an optional_dependency #192

Closed
Tracked by #181
KANAjetzt opened this issue Mar 28, 2023 · 1 comment
Closed
Tracked by #181

incompatibility should not be an optional_dependency #192

KANAjetzt opened this issue Mar 28, 2023 · 1 comment
Assignees
@KANAjetzt
Labels
validation Feature to make things safe and predictable
Milestone
3.x - v6.0.0

Comments

@KANAjetzt
Copy link
Member

KANAjetzt commented Mar 28, 2023 •
edited
Loading

nice, thanks. not sure if we need it but technically, an incompatibility should also not be an optional dependency. might not be in the scope here since the optional ones were added after this issue

Originally posted by @Qubus0 in #174 (review)
@KANAjetzt KANAjetzt self-assigned this Mar 28, 2023
@KANAjetzt KANAjetzt added the validation Feature to make things safe and predictable label Mar 28, 2023
@KANAjetzt KANAjetzt added this to the v6.0.0 milestone Mar 28, 2023
@KANAjetzt KANAjetzt mentioned this issue Mar 28, 2023
Closed
37 tasks
KANAjetzt added a commit to KANAjetzt/godot-mod-loader that referenced this issue Mar 28, 2023
@KANAjetzt
refactor: ♻️ validate_distinct_mod_ids_in_arrays()
3e2c58a 
reworked `validate_dependencies_and_incompatibilities_conflicts()` to work with any arrays, renamed it to `validate_distinct_mod_ids_in_arrays()`. Fixed the accidentally removed function call of `validate_dependencies_and_incompatibilities_conflicts()` in `_init()`. Added validation to check for distinct mod_ids in `incompatibilities` and `optional_dependencies`.

closes GodotModding#192
@KANAjetzt KANAjetzt mentioned this issue Mar 28, 2023
Merged
KANAjetzt added a commit that referenced this issue Mar 29, 2023
@KANAjetzt
refactor: ♻️ validate_distinct_mod_ids_in_arrays() (#193)
7f9afed 
* refactor: ♻️ `validate_distinct_mod_ids_in_arrays()`

reworked `validate_dependencies_and_incompatibilities_conflicts()` to work with any arrays, renamed it to `validate_distinct_mod_ids_in_arrays()`. Fixed the accidentally removed function call of `validate_dependencies_and_incompatibilities_conflicts()` in `_init()`. Added validation to check for distinct mod_ids in `incompatibilities` and `optional_dependencies`.

closes #192

* fix: 🐛 wrong return values

* feat: ✨ added `additional_info` parameter

* style: 🎨 fixed comments | added early return

* fix: 🐛 added missing return value
@KANAjetzt
Copy link
Member Author

closed by #193

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@KANAjetzt KANAjetzt

Labels
validation Feature to make things safe and predictable
Projects
None yet
Milestone
3.x - v6.0.0
Development

No branches or pull requests
1 participant
@KANAjetzt