Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: ✨ Workshop Support #148

Merged

Conversation

ithinkandicode
Copy link
Collaborator

@ithinkandicode ithinkandicode commented Feb 27, 2023

Adds workshop support, based on the code used by Brotato's current custom version of ModLoader.

Note: Includes a utility func to get the steam app ID from a file named steam_data.json, which should be in the root directory (ie. res://steam_data.json). This file is used by Godot Workshop Utility (GWU), which was developed by Brotato developer Blobfish.

Closes #106:

Adds code based on work by Blobfish for Brotato
@ithinkandicode ithinkandicode added the enhancement New feature or request label Feb 27, 2023
@ithinkandicode ithinkandicode added this to the Brotato Update milestone Feb 27, 2023
@ithinkandicode ithinkandicode linked an issue Feb 27, 2023 that may be closed by this pull request
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader_utils.gd Show resolved Hide resolved
addons/mod_loader/mod_loader_utils.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader_utils.gd Outdated Show resolved Hide resolved
@ithinkandicode
Copy link
Collaborator Author

I've made the requested edits 👍

@ithinkandicode ithinkandicode requested a review from Qubus0 March 1, 2023 00:50
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything runs smoothly on my end 👍

Thanks Darkly for implementing this 🥇
And ty Ste for reviewing.

Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some (very) tiny things

addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader_utils.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader_utils.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader_utils.gd Outdated Show resolved Hide resolved
@ithinkandicode
Copy link
Collaborator Author

Fixes lints, and added integration with ML Options (#145) \o/

@ithinkandicode ithinkandicode requested a review from KANAjetzt March 1, 2023 17:20
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 nice stuff

addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
@ithinkandicode ithinkandicode merged commit b4d31bc into GodotModding:development Mar 1, 2023
@ithinkandicode ithinkandicode deleted the workshop-support branch March 1, 2023 18:37
@ithinkandicode ithinkandicode modified the milestones: Brotato Update, v6.0.0 Mar 25, 2023
@ithinkandicode ithinkandicode changed the title Workshop Support feat: ✨ Workshop Support Jun 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Blobfish's Edits (Workshop Support)
3 participants