Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: ✨ added _remove_extension #198

Merged
merged 9 commits into from
Mar 30, 2023

Conversation

otDan
Copy link
Member

@otDan otDan commented Mar 29, 2023

Requires: #195
Adds _remove_extension that allows for removal of a specific extension, this resets the base script and then reinstalls all the other extensions in the already sorted order

@otDan otDan added the enhancement New feature or request label Mar 29, 2023
@otDan otDan added this to the v6.0.0 milestone Mar 29, 2023
@otDan otDan requested a review from a team March 29, 2023 17:25
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small code style things.
Nice work - ty.

addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
@otDan otDan requested a review from KANAjetzt March 30, 2023 09:25
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed some missing return types in my last review

addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
addons/mod_loader/mod_loader.gd Outdated Show resolved Hide resolved
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@otDan otDan added this pull request to the merge queue Mar 30, 2023
Merged via the queue into GodotModding:development with commit f11fb71 Mar 30, 2023
@otDan otDan deleted the extension-resetting-2 branch March 30, 2023 10:36
@otDan otDan mentioned this pull request Mar 31, 2023
@ithinkandicode ithinkandicode changed the title feat: added _remove_extension feat: ✨ added _remove_extension Jun 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants