v6.0.1 #302
Merged
v6.0.1 #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: 📝 updated readme with more details closes #180 * chore: 📝 moved "Godot Version" section down
* style: 🎨 added and removed whitespace * fix: ✏️ updated comment for profile and cache path * style: 🎨 added space to params and return types
Resolves a bug where the `current_user_profile` doesn't reference the Profile object in `user_profiles`. closes #290
ModLoaderUtils log deprecation messages all use `ModLoader.*`, instead of `ModLoaderUtils.*`.
* feat: ✨ added ` get_dir_paths_in_dir()` * feat: ✨ added `zip_name` and `zip_path` to `ModData` * refactor: ♻️ added `zip_path` to user profiles This allows to verify if the mod is still installed by confirming the existence of the zip file. However, this check is only performed when the mod is not loaded and a path to the zip file exists. This ensures that mods are not deleted from the profile when running in the editor. It's important to note that this new check may cause mods to appear in user profiles even if they are currently not loaded. To determine if a mod is actually loaded, you should also check `ModLoaderStore.mod_data` or use `ModLoaderMod.is_mod_loaded()`. closes #288
* fix: 🐛 check if mod zip is structured correctly * fix: 🐛 Check if mod is loaded before setting active state
It can be confusing when the assert is triggered in the utility function, as the error message is naturally more generic. Reducing it to just "error" allows the calling function to assert and provide a more detailed error message.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch v6.0.1
This patch addresses several critical issues related to the new user profiles introduced in v6.0.0. It also includes a deprecation warning fix, small code style improvements, and an improved README for the ModLoader repository.
Major bug fixes for
ModLoaderUserProfile_update_mod_list()function that is causing deactivated mods to be unintentionally enabled again. #286mod_listwhen they are disabled and Steam Workshop support is enabled. #288Deprecation warning fix
ModLoader.*#300Small code style improvements
Improved Readme for the ModLoader Repo
🚨 Breaking Changes
Mods are now always unpacked and loaded into
ModLoaderStore.mod_data. This change can potentially break Mod Lists that rely on having only loaded mods inmod_data. Consequently, these Mod Lists may display mods that are currently not loaded. To address this issue, authors of Mod Lists need to adapt their code to check the newis_activeflag.