Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

move mod_loader into an addon folder #50

Merged
merged 4 commits into from
Jan 17, 2023
Merged

move mod_loader into an addon folder #50

merged 4 commits into from
Jan 17, 2023

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Jan 16, 2023

No description provided.

ithinkandicode
ithinkandicode previously approved these changes Jan 16, 2023
Copy link
Collaborator

@ithinkandicode ithinkandicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved Folder name needs discussion

Copy link
Member

@otDan otDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to call the folder mod_loader_tools instead of just mod_loader?

@Qubus0
Copy link
Collaborator Author

Qubus0 commented Jan 16, 2023

@otDan

with the other things in there and a modularity with the interface for example it made more sense to call it a toolset, for me at least
and I feel like we'll be expanding on this thing as well
Discord ref

@ithinkandicode
Copy link
Collaborator

I do think mod_loader is cleaner. "Mod Loader Tools" suggests that it's a set of tools for the mod loader, rather than the mod loader itself

@otDan
Copy link
Member

otDan commented Jan 16, 2023

I do think mod_loader is cleaner. "Mod Loader Tools" suggests that it's a set of tools for the mod loader, rather than the mod loader itself

I agree with this

@ithinkandicode ithinkandicode self-requested a review January 17, 2023 08:01
@ithinkandicode ithinkandicode dismissed their stale review January 17, 2023 08:02

Folder name needs discussion

@Qubus0 Qubus0 requested a review from otDan January 17, 2023 10:24
@KANAjetzt
Copy link
Member

What do we do with run.gd?
Its a bit out of place.

Should be add a "game_dir_copy" folder?
Until we can get rid of run.gd.

Copy link
Collaborator

@ithinkandicode ithinkandicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go 🔥

@Qubus0
Copy link
Collaborator Author

Qubus0 commented Jan 17, 2023

run.gd won't be around for long. new flag is --script addons/mod_loader/run.gd

@Qubus0 Qubus0 merged commit e79fbba into main Jan 17, 2023
@Qubus0 Qubus0 deleted the addon branch January 17, 2023 14:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants