Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move other utils #63

Merged
merged 6 commits into from
Jan 19, 2023
Merged

Move other utils #63

merged 6 commits into from
Jan 19, 2023

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Jan 19, 2023

Needs to be merged after

No breaking changes

Moves other utility functions from ModLoader and ModData to new ModLoaderUtils class.
Only affects internal methods

@Qubus0 Qubus0 marked this pull request as ready for review January 19, 2023 22:57
@Qubus0
Merge branch 'main' into move_other_utils
b61787b 
# Conflicts:
#	addons/mod_loader/mod_data.gd
ithinkandicode
ithinkandicode approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@ithinkandicode ithinkandicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Qubus0 Qubus0 merged commit 00b711b into GodotModding:main Jan 19, 2023
@Qubus0 Qubus0 deleted the move_other_utils branch January 19, 2023 23:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ithinkandicode ithinkandicode ithinkandicode approved these changes

@KANAjetzt KANAjetzt Awaiting requested review from KANAjetzt

@otDan otDan Awaiting requested review from otDan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qubus0 @ithinkandicode