Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Stockpile --> Shopping list does not respect Contracts "Matching all" settings #403

Closed
jpkoester1 opened this issue Jul 13, 2023 · 3 comments
Labels
bug Defect done This feature will be included in the next feature release stockpile Stockpile Tool

Comments

@jpkoester1
Copy link
Contributor

Shopping list with contracts "match all" activated leads to mismatch between the stockpile window and the resulting shopping list. Please note that Nanite Repair Paste is not included in the shopping list:
image

if matching all is disabled the shopping list is exactly the same and matches the stockpile window:
image

@jpkoester1
Copy link
Contributor Author

looks like StockpileShoppingListDialog.java Line 284 iterates through all contract items no matter what the setting regarding "Match all" is.

@GoldenGnu GoldenGnu added bug Defect stockpile Stockpile Tool labels Jul 14, 2023
@GoldenGnu GoldenGnu moved this to 🪲 Bugs in jEveAssets Development Jul 14, 2023
@GoldenGnu GoldenGnu moved this from 🪲 Bugs to 🎯 In Progress in jEveAssets Development Jul 18, 2023
@GoldenGnu GoldenGnu moved this from 🎯 In Progress to 🪲 Bugs in jEveAssets Development Jul 19, 2023
@GoldenGnu GoldenGnu moved this from 🪲 Bugs to 🎯 In Progress in jEveAssets Development Jul 19, 2023
@GoldenGnu GoldenGnu self-assigned this Jul 19, 2023
@GoldenGnu
Copy link
Owner

  • StockClaim and StockItem store matching contractIDs.
  • StockClaim.matches() check contractIDs
  • StockClaim.compareTo() sort matchAll first

GoldenGnu added a commit that referenced this issue Aug 6, 2023
GoldenGnu added a commit that referenced this issue Aug 6, 2023
GoldenGnu added a commit that referenced this issue Aug 6, 2023
GoldenGnu added a commit that referenced this issue Aug 6, 2023
@GoldenGnu GoldenGnu moved this from 🎯 In Progress to ✅ Done in jEveAssets Development Aug 6, 2023
@GoldenGnu GoldenGnu added the done This feature will be included in the next feature release label Aug 6, 2023
@GoldenGnu GoldenGnu removed their assignment Aug 6, 2023
@GoldenGnu
Copy link
Owner

Released in 7.7.0
Now also works with subpiles

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Defect done This feature will be included in the next feature release stockpile Stockpile Tool
Projects
Status: 🚀 7.7.0
Development

No branches or pull requests

2 participants