Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

When including corporation contracts in the asset view the owner should be the corp instead of the character #476

Closed
jpkoester1 opened this issue Jul 8, 2024 · 2 comments
Labels
assets Assets Tool bug Defect contracts Contracts Tool done This feature will be included in the next feature release

Comments

@jpkoester1
Copy link
Contributor

I have set the "Include sell contracts" flag for the Assets tool:
image

In the Assets tool I can see a contract that has one of my characters set as its owner:
image

In the contract tool however, I can see that that contract is not owned by that character, but instead is owned by the Corporation:
image

(same behaviour in the Tree view as well)

When including contracts in the asset windows (assets and tree) the owner should be set by the following logic:

If contract.Corporation == Yes then contract.IssuerCorp else contract.Issuer

looks like you tried something like that in the past, not sure why that would be commented out:
image

Do you remember what issues you ran into here?

Thanks and best regards!

@GoldenGnu
Copy link
Owner

GoldenGnu commented Jul 9, 2024

In jEveAssets the owner is the character/corporation that got the data, if you want the corporation to be the owner, you need to add a corporation account for the corporation in question. Luckily the corporation contracts endpoint doesn’t require any roles in the corporation and is available to all members.

However, if you actually have a corporation account for the corporation, then I will consider this a bug, as it should use the corporation contracts, for corporations.

Please, let me know if this resolves your issue or if it is a bug.

Wrong again! >_<
This is a bug

@GoldenGnu GoldenGnu added question Waiting for user feedback bug Defect assets Assets Tool contracts Contracts Tool and removed question Waiting for user feedback labels Jul 9, 2024
@GoldenGnu GoldenGnu moved this to 🪲 Bugs in jEveAssets Development Jul 23, 2024
@GoldenGnu GoldenGnu self-assigned this Sep 14, 2024
@GoldenGnu GoldenGnu moved this from 🪲 Bugs to 🎯 In Progress in jEveAssets Development Sep 14, 2024
@GoldenGnu GoldenGnu moved this from 🎯 In Progress to ✅ 7.9.1 in jEveAssets Development Oct 17, 2024
@GoldenGnu GoldenGnu added the done This feature will be included in the next feature release label Oct 17, 2024
@GoldenGnu GoldenGnu removed their assignment Oct 17, 2024
@GoldenGnu
Copy link
Owner

Released in 7.9.1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
assets Assets Tool bug Defect contracts Contracts Tool done This feature will be included in the next feature release
Projects
Status: 🚀 7.9.1
Development

No branches or pull requests

2 participants