Merge pull request #181 from GoogleChrome/fix/ghost-pip-bug

Only play one video in PiP at once.
GoogleChrome · Feb 1, 2022 · 14d0740 · 14d0740
2 parents cf09a7e + ff908c3
commit 14d0740
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/js/web-components/video-player/VideoPlayer.js b/src/js/web-components/video-player/VideoPlayer.js
@@ -27,7 +27,7 @@ import {
   PIP_CLASSNAME,
 } from '../../constants';
 
-export default class extends HTMLElement {
+export default class VideoPlayer extends HTMLElement {
   /**
    * @param {VideoDownloader} downloader Video downloader associated with the current video.
    */
@@ -464,6 +464,10 @@ export default class extends HTMLElement {
       pipButton.disabled = true;
       try {
         if (this !== document.pictureInPictureElement) {
+          // If another video is already in PiP, pause it.
+          if (document.pictureInPictureElement instanceof VideoPlayer) {
+            document.pictureInPictureElement.videoElement.pause();
+          }
           await this.videoElement.requestPictureInPicture();
         } else {
           await document.exitPictureInPicture();