Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add maskable icons to manifest #146

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

beaufortfrancois
Copy link
Member

This PR adds missing maskable icons to the web app manifest as suggested by Lighthouse.

Issue: #142

@derekherman derekherman requested a review from dero September 15, 2021 06:31
Copy link
Collaborator

@dero dero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These icons look good. Tested in Chrome DevTools.

image

(But I do find it a bit funny that in order to avoid devices adding padding and white background to our icons, we... add padding and white background to our icons. 😉)

@derekherman derekherman added the bug Something isn't working label Sep 16, 2021
@beaufortfrancois
Copy link
Member Author

At least we control the padding ;)
See https://web.dev/maskable-icon/

@derekherman
Copy link
Collaborator

The padding I understand, but why the white background?

@beaufortfrancois
Copy link
Member Author

Which other color would you use? White seems appropriate to me.
I don't see how no color would match the triangle shape of the icon as well.

@derekherman
Copy link
Collaborator

My understanding is that the background should be completely filled or have none as there are different icon shapes like square, teardrop, round rectangle, and squircle that the icon can be shown in. If the background is a white circle but the theme color is dark wouldn't the icon be partially white and then outside of the circle it would be the theme color?

@dero
Copy link
Collaborator

dero commented Sep 22, 2021

@derekherman The icon background is completely filled. DevTools only previews the icon as a circle, because that is the maximum amount of crop that can be applied.

@beaufortfrancois
Copy link
Member Author

FYI I used https://maskable.app/ to create this maskable icon for kinoweb.dev.

@derekherman
Copy link
Collaborator

I see. Shouldn’t the background color be the theme color of the app then? It looks best on that dark background.

@beaufortfrancois
Copy link
Member Author

I'm not sure I like the dark background. Note that Google apps all use white background.

image
image
image

@derekherman
Copy link
Collaborator

We can leave it with the white background.

@derekherman derekherman merged commit 8eb0c72 into GoogleChrome:develop Sep 22, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants