-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add maskable icons to manifest #146
Add maskable icons to manifest #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least we control the padding ;) |
The padding I understand, but why the white background? |
Which other color would you use? White seems appropriate to me. |
My understanding is that the background should be completely filled or have none as there are different icon shapes like square, teardrop, round rectangle, and squircle that the icon can be shown in. If the background is a white circle but the theme color is dark wouldn't the icon be partially white and then outside of the circle it would be the theme color? |
@derekherman The icon background is completely filled. DevTools only previews the icon as a circle, because that is the maximum amount of crop that can be applied. |
FYI I used https://maskable.app/ to create this maskable icon for kinoweb.dev. |
I see. Shouldn’t the background color be the theme color of the app then? It looks best on that dark background. |
We can leave it with the white background. |
This PR adds missing maskable icons to the web app manifest as suggested by Lighthouse.
Issue: #142