Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add simple CSP #153

Merged
merged 3 commits into from
Sep 17, 2021
Merged

Add simple CSP #153

merged 3 commits into from
Sep 17, 2021

Conversation

beaufortfrancois
Copy link
Member

This PR adds a simple Content Security Policy as suggested by Lighthouse.

Issue: #142

@derekherman derekherman requested a review from dero September 15, 2021 06:33
dero
dero previously approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@dero dero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good basic CSP. Doesn't restrict functionality, LGTM.

derekherman
derekherman reviewed Sep 16, 2021
View reviewed changes
firebase.json Outdated Show resolved Hide resolved
@derekherman derekherman added the enhancement New feature or request label Sep 16, 2021
@beaufortfrancois @derekherman
Update firebase.json
09f2eee 
Co-authored-by: Derek Herman <derek.herman@xwp.co>
@beaufortfrancois
Copy link
Member Author

@derekherman I think we're good now.

@derekherman derekherman merged commit 27b7b9a into GoogleChrome:develop Sep 17, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@derekherman derekherman derekherman left review comments

@dero dero dero left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beaufortfrancois @dero @derekherman