-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
tests: add markdown link checker #11358
Merged
paulirish
merged 25 commits into
GoogleChrome:master
from
andreizet:markdown-links-check
Sep 13, 2020
+38
−2
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
1096aac
Added markdown links checker
andreizet d21ba74
Removed wrongly opened parenthesis from docs/readme.md
andreizet ee91506
Check links in root readme.md
andreizet ad9a004
Ignore the workflow badge when checking urls
andreizet 78384d4
Moved links checking to a separate yml
andreizet d9eaa8c
Moved links checking to a separate yml
andreizet 27899fa
Check links only for pull requests
andreizet 1ee0d9a
Run checklinks actions sequentially
andreizet 3af365e
Merged markdown links check into a single job
andreizet ee10b16
- Changed workflow's name
andreizet a069c96
- Added cron schedule
andreizet 8a6a550
- Added cron schedule
andreizet 5517211
- Added cron schedule
andreizet 1fb89d3
Added cron schedule
andreizet 15cbf96
Markdown Link Check: Run only on push
andreizet 9bc1a6e
Markdown Link Check: Run only on push
andreizet 0bf13f2
Markdown links check: ignore commits & pull requests links
andreizet d033137
Check only readme.md from root
andreizet 5a4b672
Check links without sleeping between
andreizet 89a16a6
Markdown links check: added comments
andreizet 5acdd48
Markdown links check: removed on push, added on schedule
andreizet 050a827
Markdown links check: removed working links from ignore list
andreizet e9391f3
Markdown links check: modified comments
andreizet 6d14ca3
Moved markdown.links.config.json to .github/workflows/
andreizet 638c289
Removed links checking on push
andreizet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
name: Markdown Links Check | ||
# runs every monday at 9 am | ||
on: | ||
schedule: | ||
- cron: "0 9 * * 1" | ||
|
||
jobs: | ||
check-links: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@master | ||
- uses: gaurav-nelson/github-action-markdown-link-check@v1 | ||
# checks all markdown files from /docs including all subfolders | ||
with: | ||
use-quiet-mode: 'yes' | ||
use-verbose-mode: 'yes' | ||
config-file: '.github/workflows/markdown.links.config.json' | ||
folder-path: 'docs/' | ||
- uses: actions/checkout@master | ||
- uses: gaurav-nelson/github-action-markdown-link-check@v1 | ||
# checks all markdown files from root but ignores subfolders | ||
with: | ||
use-quiet-mode: 'yes' | ||
use-verbose-mode: 'yes' | ||
config-file: '.github/workflows/markdown.links.config.json' | ||
max-depth: 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"ignorePatterns": [ | ||
{ | ||
"pattern": "^http://www.tmeter.ru" | ||
}, | ||
{ | ||
"pattern": "https://github.com/GoogleChrome/lighthouse/workflows/\uD83D\uDCA1\uD83C\uDFE0/badge.svg" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that a wrongly opened parenthesis was messing up the link. This link was not even transformed by github: https://github.com/GoogleChrome/lighthouse/blob/master/docs/readme.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! this is exactly the kind of thing I wanted to catch.