Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

clients(viewer): stop using legacy DOM api #15964

Merged
merged 4 commits into from
Apr 19, 2024
Merged

clients(viewer): stop using legacy DOM api #15964

merged 4 commits into from
Apr 19, 2024

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Apr 18, 2024 •
edited
Loading

ref #13821

@connorjclark connorjclark requested a review from a team as a code owner April 18, 2024 17:12
@connorjclark connorjclark requested review from adamraine and removed request for a team April 18, 2024 17:12
@adamraine adamraine mentioned this pull request Apr 18, 2024
Open
adamraine
adamraine reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think this is fine, but I don't think it closes #13821 for reasons mentioned in that issue

viewer/app/src/lighthouse-report-viewer.js Outdated Show resolved Hide resolved
viewer/app/src/lighthouse-report-viewer.js Show resolved Hide resolved
@devtools-bot devtools-bot merged commit 1b9e56c into main Apr 19, 2024
27 checks passed
@devtools-bot devtools-bot deleted the viewer-new-api branch April 19, 2024 21:35
@alcance alcance mentioned this pull request Jul 10, 2024
Open
@jones58 jones58 mentioned this pull request Jul 26, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @adamraine @devtools-bot