Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

optimized rendering in useEffect hook & fixed exception in data fetching #20

Merged
merged 1 commit into from
Jul 25, 2019
Merged

optimized rendering in useEffect hook & fixed exception in data fetching #20

merged 1 commit into from
Jul 25, 2019

Conversation

anton-karlovskiy
Copy link
Contributor

  1. optimized rendering times by only calling useEffect hook when the component is mounted
  2. fixed bug in data fetching project due to null or undefined of image -> exception handling

addyosmani
addyosmani approved these changes Jul 25, 2019
View reviewed changes
Copy link
Collaborator

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyosmani addyosmani merged commit 400582e into GoogleChromeLabs:master Jul 25, 2019
@anton-karlovskiy anton-karlovskiy deleted the bugfix/effect-hook-optimization branch July 25, 2019 21:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addyosmani addyosmani addyosmani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-karlovskiy @addyosmani