Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Temporarily restore STREAM_THEME_SUPPORT constant to fix fatal error when referenced #219

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

westonruter
Copy link
Collaborator

This fixes a fatal error introduced in #215 when a plugin refers to the STREAM_THEME_SUPPORT constant:

PHP Fatal error: Uncaught Error: Undefined class constant 'STREAM_THEME_SUPPORT' in /app/public/content/plugins/amp/includes/class-amp-theme-support.php:1853

The only known plugin that references this constant is the AMP plugin, which is removing stream support in ampproject/amp-wp#3059.

@westonruter westonruter added this to the 0.4 milestone Aug 21, 2019
Copy link
Collaborator

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@westonruter westonruter merged commit 4c8f2bc into master Aug 21, 2019
@westonruter westonruter deleted the fix/streaming-fatal branch August 21, 2019 22:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants