Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prefix Workbox 'Plugin' classes with the module name after renamed in v5 #220

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Prefix Workbox 'Plugin' classes with the module name after renamed in v5 #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion wp-includes/components/class-wp-service-worker-caching-routes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,9 @@ public static function prepare_strategy_args_for_js_export( $strategy_args ) {
_doing_it_wrong( 'WP_Service_Workers::register_cached_route', esc_html( sprintf( __( 'Unrecognized plugin: %s', 'pwa' ), $plugin_name ) ), '0.2' );
} else {
$plugins_js[] = sprintf(
'new wp.serviceWorker[ %s ].Plugin( %s )',
'new wp.serviceWorker[ %s ][ %s ]( %s )',
wp_service_worker_json_encode( $plugin_name ),
wp_service_worker_json_encode( ucfirst( $plugin_name ) . 'Plugin' ),
empty( $plugin_args ) ? '{}' : wp_service_worker_json_encode( $plugin_args )
);
}
Expand Down