Spa hoc touches #177
Merged
Spa hoc touches #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved react & react-dom devDependencies for now
…fest from devDependencies to dependencies
addyosmani
approved these changes
Apr 22, 2020
addyosmani
added a commit
that referenced
this pull request
Apr 24, 2020
* [core] Adds withQuicklink HOC * [infra] /chunks/ -> /react/ * [feedback] Address path fixes for build name change * [core] configured babel for transpiling the react HOC and updated extensions from mjs to js for react component to avoid errors (#175) * Spa hoc touches (#176) * infra: removed babel-preset-env in favor of @babel/preset-env and removed react & react-dom devDependencies for now * core: added react & react-dom as devDependencies and moved route-manifest from devDependencies to dependencies * Spa hoc touches (#177) * infra: removed babel-preset-env in favor of @babel/preset-env and removed react & react-dom devDependencies for now * core: added react & react-dom as devDependencies and moved route-manifest from devDependencies to dependencies * chore: removed dev console logs Co-authored-by: Anton Karlovskiy <antonkarlovskiy@outlook.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just removed dev console logs.