Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[core] configured babel for transpiling the react HOC and updated extensions from mjs to js for react component to avoid errors #175

Merged
merged 1 commit into from
Apr 21, 2020
Merged

[core] configured babel for transpiling the react HOC and updated extensions from mjs to js for react component to avoid errors #175

merged 1 commit into from
Apr 21, 2020

Conversation

anton-karlovskiy
Copy link
Contributor

@addyosmani cc @demianrenzulli

  1. configured babel to tranpile the HOC (installed relevant packages and updated .babelrc accordingly)
  2. updated naming from hoc.mjs to hoc.js to avoid errors
  3. updated naming from react-chunks.mjs to react-chunks.js to avoid errors
  4. installed react and react-dom as peerDependencies and devDependencies

@anton-karlovskiy
[core] configured babel for transpiling the react HOC and updated ext…
eca1e78 
…ensions from mjs to js for react component to avoid errors
addyosmani
addyosmani approved these changes Apr 21, 2020
View reviewed changes
Copy link
Collaborator

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyosmani addyosmani merged commit 55c4fad into GoogleChromeLabs:spa-hoc Apr 21, 2020
@addyosmani
Copy link
Collaborator

Thank you for debugging this, folks!

@anton-karlovskiy anton-karlovskiy deleted the spa-hoc-touches branch April 21, 2020 05:01
addyosmani added a commit that referenced this pull request Apr 24, 2020
@addyosmani @anton-karlovskiy
[core] Adds withQuicklink HOC (#172)
89cd6a9 
* [core] Adds withQuicklink HOC

* [infra] /chunks/ -> /react/

* [feedback] Address path fixes for build name change

* [core] configured babel for transpiling the react HOC and updated extensions from mjs to js for react component to avoid errors (#175)

* Spa hoc touches (#176)

* infra: removed babel-preset-env in favor of @babel/preset-env and removed react & react-dom devDependencies for now

* core: added react & react-dom as devDependencies and moved route-manifest from devDependencies to dependencies

* Spa hoc touches (#177)

* infra: removed babel-preset-env in favor of @babel/preset-env and removed react & react-dom devDependencies for now

* core: added react & react-dom as devDependencies and moved route-manifest from devDependencies to dependencies

* chore: removed dev console logs

Co-authored-by: Anton Karlovskiy <antonkarlovskiy@outlook.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addyosmani addyosmani addyosmani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-karlovskiy @addyosmani