Added managed memcache service and an AWS ElastiCache backend #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedsta
changed the title
tedsta
changed the title
|
@gareth-ferneyhough @yuyantingzero PTAL. Note this involves a small change to AwsFirewall |
gareth-ferneyhough
suggested changes
Mar 29, 2017
| benchmark_spec.always_call_cleanup = True | ||
|
|
||
| if FLAGS.memcached_managed == providers.GCP: | ||
| raise Exception("GCP managed memcached backend not implemented yet") |
There was a problem hiding this comment.
I would use NotImplementedError
| if FLAGS.memcached_managed == providers.GCP: | ||
| raise Exception("GCP managed memcached backend not implemented yet") | ||
| elif FLAGS.memcached_managed == providers.AWS: | ||
| ycsb_backend = 'memcached' |
There was a problem hiding this comment.
Maybe make this string a constant at the top of file since it is used multiple times.
| @@ -0,0 +1,35 @@ | |||
| # Copyright 2016 PerfKitBenchmarker Authors. All rights reserved. | |||
| @@ -0,0 +1,135 @@ | |||
| # Copyright 2016 PerfKitBenchmarker Authors. All rights reserved. | |||
| def Create(self): | ||
| # Open the port memcached needs | ||
| aws_network.AwsFirewall.GetFirewall() \ | ||
| .AllowPortInSecurityGroup(self.region, self.security_group_id, 11211) |
There was a problem hiding this comment.
Make port number (11211) a constant
| cmd = ['aws', 'elasticache', 'delete-cache-cluster', | ||
| '--cache-cluster-id=%s' % self.cluster_id, | ||
| '--region=%s' % self.region] | ||
| out, _, _ = vm_util.IssueCommand(cmd) |
There was a problem hiding this comment.
If you aren't using out, do you need to save it and its underscore friends?
| @@ -0,0 +1,39 @@ | |||
| # Copyright 2016 PerfKitBenchmarker Authors. All rights reserved. | |||
tedsta
force-pushed
the
elasticache
branch
2 times, most recently
from
4c07286 to
1b4dd7c
Compare
gareth-ferneyhough
approved these changes
Apr 3, 2017
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an abstraction over managed memcached services and implements an ElastiCache backend. It also adds a managed scenario to the memcached ycsb benchmark
TL;DR you can now run memcached ycsb against ElastiCache.