Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix broken regular expression and make test more robust. #1311

Merged
merged 2 commits into from
Mar 31, 2017
Merged

Fix broken regular expression and make test more robust. #1311

merged 2 commits into from
Mar 31, 2017

Conversation

yuyantingzero
Copy link
Contributor

No description provided.

@yuyantingzero yuyantingzero mentioned this pull request Mar 8, 2017
Closed
dlott
dlott reviewed Mar 9, 2017
View reviewed changes
perfkitbenchmarker/linux_packages/blazemark.py Outdated
@@ -159,6 +160,7 @@ def _ParseResult(out, test):
if filled:
metadata['% filled'] = regex_util.ExtractFloat(FILLED_REGEX, filled)
unit = m[-2]
print m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover debugging statement?

@yuyantingzero
Copy link
Contributor Author

@dlott PTAL

@dlott
Copy link
Contributor

dlott commented Mar 13, 2017

LGTM

@yuyantingzero yuyantingzero merged commit 8c92c13 into master Mar 31, 2017
@yuyantingzero yuyantingzero deleted the blazemark-parser branch March 31, 2017 21:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dlott dlott dlott left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuyantingzero @dlott @googlebot