Make Prompts Reusable for Very Large Experements #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bslabe123
requested review from
achandrasekar,
ahg-g,
annapendleton and
jjk-g
as code owners
benchmarks/benchmark/tools/profile-generator/container/benchmark_serving.py
Show resolved
Hide resolved
annapendleton
approved these changes
Nov 19, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently cannot run experements where the number of prompts exceeds the size of the dataset (for us ~30k prompts), this change makes it so we now instead just filter the dataset and then select randomly from it.