Skip to content

add --host command line argument #20

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 20, 2020
Merged

add --host command line argument #20

merged 5 commits into from
Feb 20, 2020

Conversation

kanekv
Copy link
Contributor

@kanekv kanekv commented Feb 19, 2020

Fixes #19

@di
Copy link
Member

di commented Feb 19, 2020

Thanks @kanekv!

Can you document this in this section of the README, and add a line to the changelog as well?

@kanekv
Copy link
Contributor Author

kanekv commented Feb 20, 2020

@di done

@di
Copy link
Member

di commented Feb 20, 2020

@kanekv I'll do the version bump in a separate PR, please add the changelog entry under the "Unreleased" header.

di
di reviewed Feb 20, 2020
View reviewed changes
@kanekv
Copy link
Contributor Author

kanekv commented Feb 20, 2020

@di looks better now?

@di di merged commit 33f629e into GoogleCloudPlatform:master Feb 20, 2020
@di
Copy link
Member

di commented Feb 20, 2020

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@di di

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make host configurable
3 participants
@kanekv @di @googlebot