Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(batch): valid date format layout #4252

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

Deleplace
Copy link
Contributor

Part of #4246

"2006-12-25" is not a valid date format layout in Go, and time.Now().Format("2006-12-25") changes every second, which may have caused test flakiness in the past.

Replacing with "2006-01-02" which means "YYYY-MM-DD" (doc)

@Deleplace Deleplace requested review from a team as code owners July 3, 2024 14:16
@product-auto-label product-auto-label bot added api: batch Issues related to the Batch API. samples Issues that are directly related to samples. labels Jul 3, 2024
@Deleplace Deleplace enabled auto-merge (squash) July 3, 2024 15:48
@Sita04 Sita04 removed their assignment Jul 9, 2024
@Deleplace Deleplace merged commit eb1408f into GoogleCloudPlatform:main Jul 19, 2024
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: batch Issues related to the Batch API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants