Some Trivial Tests (#189)

* Some Trivial Tests

* Check style isn't my friend today.

Several changes due to weird imports in IntelliJ.

appengine/guestbook-objectify/pom.xml

@@ -6,7 +6,7 @@
     <version>1.0-SNAPSHOT</version>
 
     <groupId>com.example.appengine</groupId>
-    <artifactId>guestbook</artifactId>
+    <artifactId>appengine-guestbook-objectify</artifactId>
     <properties>
         <objectify.version>5.1.5</objectify.version>
         <guava.version>18.0</guava.version>
@@ -57,6 +57,18 @@
 <!-- [END Objectify_Dependencies] -->
 
         <!-- Test Dependencies -->
+        <dependency>
+            <groupId>junit</groupId>
+            <artifactId>junit</artifactId>
+            <version>4.12</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-all</artifactId>
+            <version>1.10.19</version>
+            <scope>test</scope>
+        </dependency>
         <dependency>
             <groupId>com.google.appengine</groupId>
             <artifactId>appengine-testing</artifactId>
@@ -69,6 +81,19 @@
             <version>${appengine.sdk.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>com.google.appengine</groupId>
+            <artifactId>appengine-tools-sdk</artifactId>
+            <version>${appengine.sdk.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>com.google.truth</groupId>
+            <artifactId>truth</artifactId>
+            <version>0.28</version>
+            <scope>test</scope>
+        </dependency>
+
     </dependencies>
 
     <build>

appengine/guestbook-objectify/src/test/java/com/example/guestbook/GreetingTest.java

@@ -0,0 +1,84 @@
+/*
+ * Copyright 2016 Google Inc. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.example.guestbook;
+
+import static com.example.guestbook.GuestbookTestUtilities.cleanDatastore;
+import static org.junit.Assert.assertEquals;
+
+import com.google.appengine.api.datastore.DatastoreService;
+import com.google.appengine.api.datastore.DatastoreServiceFactory;
+import com.google.appengine.api.datastore.Entity;
+import com.google.appengine.api.datastore.KeyFactory;
+import com.google.appengine.api.datastore.PreparedQuery;
+import com.google.appengine.api.datastore.Query;
+import com.google.appengine.tools.development.testing.LocalDatastoreServiceTestConfig;
+import com.google.appengine.tools.development.testing.LocalServiceTestHelper;
+
+import com.googlecode.objectify.ObjectifyService;
+import com.googlecode.objectify.util.Closeable;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+
+@RunWith(JUnit4.class)
+public class GreetingTest {
+  private static final String TEST_CONTENT = "The world is Blue today";
+
+  private final LocalServiceTestHelper helper =
+      new LocalServiceTestHelper(
+          // Set no eventual consistency, that way queries return all results.
+          // https://cloud.google.com/appengine/docs/java/tools/localunittesting#Java_Writing_High_Replication_Datastore_tests
+          new LocalDatastoreServiceTestConfig()
+              .setDefaultHighRepJobPolicyUnappliedJobPercentage(0));
+
+  private Closeable closeable;
+  private DatastoreService ds;
+
+  @Before
+  public void setUp() throws Exception {
+
+    helper.setUp();
+    ds = DatastoreServiceFactory.getDatastoreService();
+
+    ObjectifyService.register(Guestbook.class);
+    ObjectifyService.register(Greeting.class);
+
+    closeable = ObjectifyService.begin();
+
+    cleanDatastore(ds, "default");
+  }
+
+  @After
+  public void tearDown() {
+    cleanDatastore(ds, "default");
+    helper.tearDown();
+    closeable.close();
+  }
+
+  @Test
+  public void createSaveObject() throws Exception {
+
+    Greeting g = new Greeting("default", TEST_CONTENT);
+    ObjectifyService.ofy().save().entity(g).now();
+
+    Query query = new Query("Greeting")
+        .setAncestor(new KeyFactory.Builder("Guestbook", "default").getKey());
+    PreparedQuery pq = ds.prepare(query);
+    Entity greeting = pq.asSingleEntity();    // Should only be one at this point.
+    assertEquals(greeting.getProperty("content"), TEST_CONTENT);
+  }
+}

appengine/guestbook-objectify/src/test/java/com/example/guestbook/GuestbookTestUtilities.java

@@ -0,0 +1,43 @@
+/*
+ * Copyright 2016 Google Inc. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.example.guestbook;
+
+import com.google.appengine.api.datastore.DatastoreService;
+import com.google.appengine.api.datastore.Entity;
+import com.google.appengine.api.datastore.FetchOptions;
+import com.google.appengine.api.datastore.Key;
+import com.google.appengine.api.datastore.KeyFactory;
+import com.google.appengine.api.datastore.PreparedQuery;
+import com.google.appengine.api.datastore.Query;
+
+import java.util.ArrayList;
+import java.util.List;
+
+public class GuestbookTestUtilities {
+
+  public static void cleanDatastore(DatastoreService ds, String book) {
+    Query query = new Query("Greeting")
+        .setAncestor(new KeyFactory.Builder("Guestbook", book)
+            .getKey()).setKeysOnly();
+    PreparedQuery pq = ds.prepare(query);
+    List<Entity> entities = pq.asList(FetchOptions.Builder.withDefaults());
+    ArrayList<Key> keys = new ArrayList<>(entities.size());
+
+    for (Entity e : entities) {
+      keys.add(e.getKey());
+    }
+    ds.delete(keys);
+  }
+
+}

appengine/guestbook-objectify/src/test/java/com/example/guestbook/SignGuestbookServletTest.java

@@ -0,0 +1,118 @@
+/*
+ * Copyright 2015 Google Inc. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.example.guestbook;
+
+import static com.example.guestbook.GuestbookTestUtilities.cleanDatastore;
+import static org.junit.Assert.assertEquals;
+import static org.mockito.Mockito.when;
+
+import com.google.appengine.api.datastore.DatastoreService;
+import com.google.appengine.api.datastore.DatastoreServiceFactory;
+import com.google.appengine.api.datastore.Entity;
+import com.google.appengine.api.datastore.KeyFactory;
+import com.google.appengine.api.datastore.PreparedQuery;
+import com.google.appengine.api.datastore.Query;
+import com.google.appengine.tools.development.testing.LocalDatastoreServiceTestConfig;
+import com.google.appengine.tools.development.testing.LocalServiceTestHelper;
+
+import com.googlecode.objectify.ObjectifyService;
+import com.googlecode.objectify.util.Closeable;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import java.io.PrintWriter;
+import java.io.StringWriter;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+/**
+ * Unit tests for {@link com.example.guestbook.SignGuestbookServlet}.
+ */
+@RunWith(JUnit4.class)
+public class SignGuestbookServletTest {
+  private static final String FAKE_URL = "fakey.org/sign";
+  private static final String FAKE_NAME = "Fake";
+
+  private final LocalServiceTestHelper helper =
+      new LocalServiceTestHelper(
+          // Set no eventual consistency, that way queries return all results.
+          // https://cloud.google.com/appengine/docs/java/tools/localunittesting#Java_Writing_High_Replication_Datastore_tests
+          new LocalDatastoreServiceTestConfig()
+              .setDefaultHighRepJobPolicyUnappliedJobPercentage(0));
+
+  private final String testPhrase = "Noew is the time";
+
+  @Mock private HttpServletRequest mockRequest;
+
+  @Mock
+  private HttpServletResponse mockResponse;
+
+  private StringWriter stringWriter;
+  private SignGuestbookServlet servletUnderTest;
+  private Closeable closeable;
+  private DatastoreService ds;
+
+  @Before
+  public void setUp() throws Exception {
+
+    MockitoAnnotations.initMocks(this);
+    helper.setUp();
+    ds = DatastoreServiceFactory.getDatastoreService();
+
+    //  Set up some fake HTTP requests
+    when(mockRequest.getRequestURI()).thenReturn(FAKE_URL);
+    when(mockRequest.getParameter("guestbookName")).thenReturn( "default" );
+    when(mockRequest.getParameter("content")).thenReturn( testPhrase );
+
+    stringWriter = new StringWriter();
+    when(mockResponse.getWriter()).thenReturn(new PrintWriter(stringWriter));
+
+    servletUnderTest = new SignGuestbookServlet();
+
+    ObjectifyService.register(Guestbook.class);
+    ObjectifyService.register(Greeting.class);
+
+    closeable = ObjectifyService.begin();
+
+    cleanDatastore(ds, "default");
+  }
+
+  @After public void tearDown() {
+    cleanDatastore(ds, "default");
+    helper.tearDown();
+    closeable.close();
+  }
+
+  @Test
+  public void doPost_userNotLoggedIn() throws Exception {
+    servletUnderTest.doPost(mockRequest, mockResponse);
+
+    Query query = new Query("Greeting")
+        .setAncestor(new KeyFactory.Builder("Guestbook", "default").getKey());
+    PreparedQuery pq = ds.prepare(query);
+
+    Entity greeting = pq.asSingleEntity();    // Should only be one at this point.
+    assertEquals(greeting.getProperty("content"), testPhrase);
+  }
+
+}