Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Exclude generated code files from code coverage. #198

Closed
wants to merge 1 commit into from
Closed

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Apr 26, 2016

This was causing the Coveralls plugin to fail with "Source not found".

This was causing the Coveralls plugin to fail with "Source not found".
@tswast
Copy link
Contributor Author

tswast commented Apr 26, 2016

@lesv One more change to coverage plugin.

I was able to manually run the plugin. Hopefully this means we'll get a coverage report after Travis finishes.

mvn clean cobertura:cobertura coveralls:report -DrepoToken=OUR-TOKEN

I'm thinking we should reconsider how we handle protocol buffers, since this will be a pain to maintain, and I'm afraid we might exclude more than we mean to.

@tswast
Copy link
Contributor Author

tswast commented Apr 26, 2016

Ugh. Coveralls had another error when running on Travis.

[ERROR] Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.1.0:report (default-cli) on project doc-samples: Build error: Line number 52 is greater than the source file appengine/datastore/src/main/java/com/example/appengine/Greeting.java size -> [Help 1]

I'll look into this.

@tswast
Copy link
Contributor Author

tswast commented Apr 26, 2016

"My guess is that you have multi-module project containing duplicate package/class names"
trautonen/coveralls-maven-plugin#73 (comment)

We probably do this. I think I use the com.example.appengine in multiple modules. I'll see about pulling some of them into unique names.

@tswast
Copy link
Contributor Author

tswast commented Apr 26, 2016

I'll close this for now. Hopefully codecov works better. #199

@tswast tswast closed this Apr 26, 2016
@lesv lesv deleted the coveralls branch April 26, 2016 23:18
minherz pushed a commit that referenced this pull request Nov 9, 2022
minherz pushed a commit that referenced this pull request Nov 10, 2022
minherz pushed a commit that referenced this pull request Nov 10, 2022
charlieyu1996 pushed a commit that referenced this pull request Nov 10, 2022
….1 (#198)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud:libraries-bom](https://github.com/GoogleCloudPlatform/cloud-opensource-java) | patch | `7.0.0` -> `7.0.1` |

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-talent).
bourgeoisor pushed a commit that referenced this pull request Nov 11, 2022
….0 (#198)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud:libraries-bom](https://github.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `5.4.0` -> `5.5.0` |

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-dataproc).
Sita04 pushed a commit that referenced this pull request Nov 11, 2022
Sita04 pushed a commit that referenced this pull request Jan 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant