Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: dataproc instantiate inline workflow sample #2360

Merged
merged 8 commits into from
Mar 24, 2020
Merged

feat: dataproc instantiate inline workflow sample #2360

merged 8 commits into from
Mar 24, 2020

Conversation

bradmiro
Copy link
Contributor

@bradmiro bradmiro commented Mar 9, 2020

Adding a sample showing how to instantiate an inline workflow for dataproc.

@bradmiro bradmiro requested a review from a team March 9, 2020 21:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2020
@bradmiro bradmiro assigned kurtisvg and unassigned nnegrey Mar 9, 2020
@lesv lesv assigned lesv and unassigned kurtisvg Mar 9, 2020
lesv
lesv approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This basically appears ok, but I question why it's a useful example/sample. What are you teaching users by using a preinstalled jar?

@lesv
Copy link
Contributor

lesv commented Mar 10, 2020

Do you need me to merge?

@bradmiro
Copy link
Contributor Author

I can merge! I'm finishing these up in a couple other languages and will merge when all are done, probably tomorrow :) thanks!

@bradmiro bradmiro merged commit c3bccc3 into master Mar 24, 2020
@bradmiro bradmiro deleted the dataproc-samples branch March 24, 2020 16:49
bourgeoisor pushed a commit that referenced this pull request Nov 11, 2022
@bradmiro @chingor13
samples: feat: dataproc instantiate inline workflow sample (#2360)
0bd96fd 
* Adding Dataproc InstantiateInlineWorkFlow samples
@bourgeoisor bourgeoisor mentioned this pull request Nov 11, 2022
Merged
9 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@lesv lesv

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bradmiro @lesv @googlebot @nnegrey @kurtisvg