Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(containerattached): Add security_posture_config #11516

Merged
merged 10 commits into from
Sep 6, 2024

Conversation

hdp617
Copy link
Contributor

@hdp617 hdp617 commented Aug 21, 2024

Adds support for configuring Security Posture.

Release Note Template for Downstream PRs (will be copied)

containerattached: added `security_posture_config` field to `google_container_attached_cluster` resource

@github-actions github-actions bot requested a review from shuyama1 August 21, 2024 18:18
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 115 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 115 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 34 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 3 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 4
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • containerattached

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerAttachedCluster_containerAttachedClusterFullExample
  • TestAccContainerAttachedCluster_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAttachedCluster_containerAttachedClusterFullExample[Error message] [Debug log]
TestAccContainerAttachedCluster_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 115 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 115 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 34 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 3 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 4
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • containerattached

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerAttachedCluster_containerAttachedClusterFullExample
  • TestAccContainerAttachedCluster_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAttachedCluster_containerAttachedClusterFullExample[Error message] [Debug log]
TestAccContainerAttachedCluster_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 115 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 115 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 34 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 3 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 4
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • containerattached

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerAttachedCluster_containerAttachedClusterFullExample
  • TestAccContainerAttachedCluster_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAttachedCluster_containerAttachedClusterFullExample[Error message] [Debug log]
TestAccContainerAttachedCluster_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both tests failed with error:

vcr_utils.go:152: Step 1/10 error: Error running apply: exit status 1
        
        Error: Error creating Cluster: googleapi: Error 400: Invalid Security Posture config. Security Posture is not supported in this version., field: attached_cluster.security_posture_config
        Details:
        [
          {
            "@type": "type.googleapis.com/google.rpc.BadRequest",
            "fieldViolations": [
              {
                "description": "Invalid Security Posture config. Security Posture is not supported in this version.",
                "field": "attached_cluster.security_posture_config"
              }
            ]
          }
        ]
        
          with google_container_attached_cluster.primary,
          on terraform_plugin_test.tf line 10, in resource "google_container_attached_cluster" "primary":
          10: resource "google_container_attached_cluster" "primary" {

Are you able to get tests passed locally? Let me know if you need help with debugging the issue. Thanks!

@hdp617
Copy link
Contributor Author

hdp617 commented Aug 22, 2024

Are you able to get tests passed locally? Let me know if you need help with debugging the issue. Thanks!

This is expected as the version that supports the feature is not fully rolled out yet. I'll rerun the test and let you know once it's ready. Thanks!

@github-actions github-actions bot requested a review from shuyama1 August 22, 2024 17:45
@github-actions github-actions bot requested a review from shuyama1 August 23, 2024 17:01
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 109 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 109 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 34 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 3 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 4
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • containerattached

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerAttachedCluster_containerAttachedClusterFullExample
  • TestAccContainerAttachedCluster_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAttachedCluster_containerAttachedClusterFullExample[Error message] [Debug log]
TestAccContainerAttachedCluster_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll convert the PR to draft for now to disable reviewer reminders. Feel free to convert it back when the backend is released and the PR is ready for review. Thanks!

@shuyama1 shuyama1 marked this pull request as draft August 23, 2024 18:41
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 107 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 107 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 3 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 4
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • containerattached

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerAttachedCluster_containerAttachedClusterFullExample
  • TestAccContainerAttachedCluster_update

Get to know how VCR tests work

@hdp617 hdp617 marked this pull request as ready for review September 5, 2024 15:29
@github-actions github-actions bot requested a review from shuyama1 September 5, 2024 15:30
@shuyama1
Copy link
Member

shuyama1 commented Sep 6, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 107 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 107 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 3 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 4
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • containerattached

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerAttachedCluster_containerAttachedClusterFullExample
  • TestAccContainerAttachedCluster_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerAttachedCluster_containerAttachedClusterFullExample[Debug log]
TestAccContainerAttachedCluster_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants