Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

container: bump additive_vpc_scope_dns_domain to GA #11545

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Aug 25, 2024

Release Note Template for Downstream PRs (will be copied)

container: promoted the `additive_vpc_scope_dns_domain` field on the `google_container_cluster` resource to GA

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from SarahFrench August 25, 2024 16:07
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 25, 2024
Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I'm OOO and will review this on Tuesday, but I'll trigger the tests now

@modular-magician modular-magician added service/container and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 26, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 54 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@SarahFrench
Copy link
Contributor

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 27, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 54 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@SarahFrench
Copy link
Contributor

SarahFrench commented Aug 27, 2024

Note to self: As the automated tests on PRs use only the Beta provider, I'm running TestAccContainerCluster_withAdditiveVPC in a build in TC using the GA provider

Edit: that passed ok, I'm now running 4 random tests just to double check

@SarahFrench SarahFrench merged commit b7538e9 into GoogleCloudPlatform:main Aug 28, 2024
12 of 13 checks passed
iyabchen pushed a commit to iyabchen/magic-modules that referenced this pull request Sep 14, 2024
@DrFaust92 DrFaust92 deleted the additive-vpc-ga branch November 25, 2024 02:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants