add Large Volumes support for netapp volumes

[Mehul3217]

Release Note Template for Downstream PRs (will be copied)

netapp: added `large_capacity` and `multiple_endpoints` to `google_netapp_volume` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 53 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 74 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume" "primary" {
  large_capacity     = # value needed
  multiple_endpoints = # value needed
}

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 18
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• netapp

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[zli82016]

Do you mind adding adding a create test and a update test for the new fields?

Doc: https://googlecloudplatform.github.io/magic-modules/develop/test/test/#before-you-begin

[zli82016]

Also, the conflicts need to be resolved.

[Mehul3217]

Do you mind adding adding a create test and a update test for the new fields?

Doc: https://googlecloudplatform.github.io/magic-modules/develop/test/test/#before-you-begin

Creating Large Volume is a high resource intensive process and by nature of design of this feature it limits the total number of large volumes for a particular region which will restrict the user if we add tests for this.

We already have this feature in Terraform EAP provider which is shared with customers and working fine.

[Mehul3217]

Also, the conflicts need to be resolved.

Done

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 74 insertions(+))
google-beta provider: Diff ( 2 files changed, 74 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume" "primary" {
  large_capacity     = # value needed
  multiple_endpoints = # value needed
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 74 insertions(+))
google-beta provider: Diff ( 2 files changed, 74 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume" "primary" {
  large_capacity     = # value needed
  multiple_endpoints = # value needed
}

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 18
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• netapp

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 18
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• netapp

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[zli82016]

LGTM. Thanks for working on this.