Add support for routing_mode to google_network_services_gateway

[Samir-Cit]

Hello folks.

This PR is to add the support for Secure Web Proxy as a Next Hop by adding routing_mode field with possible values EXPLICIT_ROUTING_MODE and NEXT_HOP_ROUTING_MODE to the google_network_services_gateway resource

Release Note Template for Downstream PRs (will be copied)

networkservices: added `routing_mode` field to `google_network_services_gateway` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 267 insertions(+))
google-beta provider: Diff ( 5 files changed, 267 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 3 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1070
Passed tests: 986
Skipped tests: 75
Affected tests: 9

Click here to see the affected service packages

• compute
• networkservices

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway
• TestAccNetworkServicesGateway_minimalSwp
• TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork
• TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork
• TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample
• TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample
• TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyWithoutAddresses
• TestAccNetworkServicesGateway_swpAsNextHop
• TestAccNetworkServicesGateway_updateSwp

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway[Debug log]
TestAccNetworkServicesGateway_minimalSwp[Debug log]
TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork[Debug log]
TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork[Debug log]
TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample[Debug log]
TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample[Debug log]
TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyWithoutAddresses[Debug log]
TestAccNetworkServicesGateway_swpAsNextHop[Debug log]
TestAccNetworkServicesGateway_updateSwp[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 268 insertions(+))
google-beta provider: Diff ( 5 files changed, 268 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 3 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1070
Passed tests: 995
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages

• compute
• networkservices

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[zli82016]

Hello, @Samir-Cit , adding a required field is a breaking change in Terraform provider and is not allowed in the provider minor version release. But the new field can be added in the next major release (7.0) of providers.

This is the doc. Feel free to let me know if you have any questions.

Also, is there Github issue for this PR? Thanks.

[Samir-Cit]

Hello, @Samir-Cit , adding a required field is a breaking change in Terraform provider and is not allowed in the provider minor version release. But the new field can be added in the next major release (7.0) of providers.

This is the doc. Feel free to let me know if you have any questions.

Also, is there Github issue for this PR? Thanks.

Hello @zli82016
Got it, there's no problem this change go in the next major release.

I don't believe we have a Github issue for this. I work with @naveen and this task was on our backlog.
But I'll double check and ask him, if we have I'll put it here!

[zli82016]

Hello, @Samir-Cit , adding a required field is a breaking change in Terraform provider and is not allowed in the provider minor version release. But the new field can be added in the next major release (7.0) of providers.
This is the doc. Feel free to let me know if you have any questions.
Also, is there Github issue for this PR? Thanks.

Hello @zli82016 Got it, there's no problem this change go in the next major release.

I don't believe we have a Github issue for this. I work with @naveen and this task was on our backlog. But I'll double check and ask him, if we have I'll put it here!

Thank you for your understanding.

If there isn't a Github issue, feel free to create one, which will help to track it in the next major release.

Feel free to close this PR. Thanks.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 261 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 261 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 3 insertions(+))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 47
Skipped tests: 1
Affected tests: 7

Click here to see the affected service packages

• networkservices

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkServicesGateway_minimalSwp
• TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork
• TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork
• TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample
• TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample
• TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyWithoutAddresses
• TestAccNetworkServicesGateway_swpUpdate

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_minimalSwp[Debug log]
TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork[Debug log]
TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork[Debug log]
TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyWithoutAddresses[Debug log]
TestAccNetworkServicesGateway_swpUpdate[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample[Error message] [Debug log]
TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 255 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 255 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 55
Passed tests: 52
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

• networkservices

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample
• TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample[Debug log]
TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[zli82016]

LGTM. Thanks.