-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Make (R)IGM.PerInstanceConfigs lock on Instance name, not IGM #12829
Make (R)IGM.PerInstanceConfigs lock on Instance name, not IGM #12829
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1096 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving since this follows the mutex format in docs: https://googlecloudplatform.github.io/magic-modules/reference/resource/#mutex
Allow parallelization of per instance config related operations by not locking on the IGM
Fixes b/270736647
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.