Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added IAP enable/disable field #12921

Closed

Conversation

Deepraj1996
Copy link

cloudrunv2: added `iap_enabled` field to `google_cloud_run_v2_service` (beta).

Copy link

google-cla bot commented Jan 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/run and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 30, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 29 insertions(+))
google-beta provider: Diff ( 5 files changed, 177 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 52
Passed tests: 45
Skipped tests: 5
Affected tests: 2

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceIapExample
  • TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceIapExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 5, 2025
@Deepraj1996 Deepraj1996 closed this Feb 5, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants