Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add wasmAction field to EdgeCacheService #13123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JayanSmart
Copy link

@JayanSmart JayanSmart commented Feb 19, 2025

Add field wasmAction to the route_action object.

Fixes: hashicorp/terraform-provider-google#21013

networkservices: added `wasmAction` field to `google_network_services_edge_cache_service` resource

Copy link

google-cla bot commented Feb 19, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from ScottSuarez February 19, 2025 15:58
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/networkservices-media-cdn and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 19, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 508 insertions(+))
google-beta provider: Diff ( 5 files changed, 508 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 290 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 59
Passed tests: 56
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • networkservices

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedBetaExample
  • TestAccNetworkServicesEdgeCacheService_updateAndImport

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedBetaExample [Error message] [Debug log]
TestAccNetworkServicesEdgeCacheService_updateAndImport [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@@ -0,0 +1,189 @@
resource "google_storage_bucket" "dest" {
provider = google-beta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing because provider = google-beta is tagged here but the test is not labeled as being a beta test

Copy link
Contributor

@ScottSuarez ScottSuarez Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see /mmv1/api/resource/examples.go#L132

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While making that change I realised that the field is supported in the GA api already - I have removed references to beta in my PR.

@JayanSmart
Copy link
Author

While making that change I realised that the field is supported in the GA api already - I have removed references to beta in my PR.

@github-actions github-actions bot requested a review from ScottSuarez February 21, 2025 12:49
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 21, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/networkservices-media-cdn
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing MediaCDN routeAction - wasmAction
3 participants