Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added missing service label handling to generate_comment #13143

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

melinath
Copy link
Member

Fixed hashicorp/terraform-provider-google#21287

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1010 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1010 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 127 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_not_a_resource (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_not_a_resource" "primary" {
  description  = # value needed
  display_name = # value needed
  encryption_spec {
    kms_key_name = # value needed
  }
  labels = # value needed
  region = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_not_a_resource

If you believe this detection to be incorrect please raise the concern with your reviewer.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 58
Passed tests: 55
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

@melinath melinath requested review from a team and trodge and removed request for a team February 21, 2025 17:37
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect when resources are added that aren't covered by existing service labels
2 participants