-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added missing service label handling to generate_comment #13143
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_not_a_resource" "primary" {
description = # value needed
display_name = # value needed
encryption_spec {
kms_key_name = # value needed
}
labels = # value needed
region = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. |
Tests analyticsTotal tests: 58 Click here to see the affected service packages
🟢 All tests passed! View the build log |
This reverts commit 3f72d3a.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Fixed hashicorp/terraform-provider-google#21287
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.