Fixes flaky TestAccSqlDatabaseInstance_activationPolicy test, makes run sequential #13152
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL test method
TestAccSqlDatabaseInstance_activationPolicyis flaky, as the test steps are curated (and expected) to run one after the other. But currently parallel execution is enabled for the test steps (reference) usingParallel(), which enables unordered execution making the test flaky.Debug logs showing how, (steps), after the
MySQL 8_0_18step, theMySQL 8_4step got executed before theMySQL 8_0_37step, creating this error:"Invalid request: To upgrade to MySQL 8.4 source version should be 8.0.37 or higher.". This issue surfaced in this PR: #13090.